Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clean up addEnvVariables function #1124

Merged
merged 2 commits into from
Aug 26, 2020
Merged

refactor: clean up addEnvVariables function #1124

merged 2 commits into from
Aug 26, 2020

Conversation

erezrokah
Copy link
Contributor

This extracts some code into functions (with descriptive names) and removes a redundant argument to addEnvVariables

@erezrokah erezrokah added the type: chore work needed to keep the product and development running smoothly label Aug 20, 2020
@erezrokah erezrokah requested a review from ehmicky August 20, 2020 17:26
@erezrokah erezrokah merged commit 31d6630 into master Aug 26, 2020
@erezrokah erezrokah deleted the refactor/extract_logic branch August 26, 2020 08:15
@snyk-bot snyk-bot mentioned this pull request Aug 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmicky ehmicky ehmicky approved these changes

Assignees
No one assigned
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erezrokah @ehmicky